-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt submission #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission!
Could you add the lines below in your model-metadata?
schema version (please add it in the first line as is:)
schema_version: "https://raw.githubusercontent.com/Infectious-Disease-Modeling-Hubs/schemas/main/v2.0.
0/admin-schema.json"
website_url
it is needed as a required property like:
website_url: "https://url_to_yourmodel_website.com"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
we don't currently have a website
Teresa, we were not very clear in the instructions, so I need to apologize. The Also, there seems to be a problem with a ":" in your metadata. Thanks! Shaun |
@shauntruelove No worries, I changed the date. Also added a space after a ":", hopefully that solves the metadata issue? You're probably aware but just in case you're not, the guidelines in the word doc says the origin date is the Saturday following the submission Due Date, in case you want to update that. |
@tkcy As for metadata, could you chenge the license line as: license: "CC-BY-4.0" sorry for the inconvenience, but this should resolve the error on model-metadata |
@tkcy Could you double check the content of .parquet in view of column 'type'? And on the 2nd message, I think it was about 'horizon'. In the hub configuration we need [1-4] as required, but owing to the type error beforehand this message might be shown. Please check the content out firsst. Notice: ! 2024-02-25-CU-RSV_SVIRS.parquet: Column data types do not match hub schema. We are now investigating on the above, please give us time(we apologize for the inconvenience) Thank you Koji |
@kjsato trying again |
@tkcy thanks! and sorry for the inconvenience. I updated tasks.json in main, could you merge or replace it in your Then I think the submission will pass if you can resolve the mismatches that appeared in the Notice line above. |
Hrm so we had this problem with the origin datetime format for our RSV scenario hub submission - my computer somehow adds time zone info that is not visible on my end. it was solved there by converting to character format. Maybe I'll try going back to character. |
Coud you use below for example before saving the data without changing the type "Date"? |
Okay, if other errors are resolved, I will transform the column as simple ones then issue an new pr with this reference on my side
Yes, once if possible.
so please pay attention that the others will be handled as invalid. |
The attached parquet is the revision which I made converted the origin_date column. Just FYI(gzipped to attach here 2024-02-25-CU-RSV_SVIRS.parquet.gz). By using it, only one remaining issue is:
Please take a look at the contents and see if there is a possibility of correction |
I don't know how to resolve - I'm entering as specified but the precision of doubles in Matlab is 16 decimal places. I would suggest accepting this column as a character array.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Koji SATO ***@***.***>
Sent: Thursday, February 29, 2024 3:56:39 PM
To: HopkinsIDD/rsv-forecast-hub ***@***.***>
Cc: Yamana, Teresa K. ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [HopkinsIDD/rsv-forecast-hub] attempt submission (PR #7)
The attached parquet is the revision which I made converted the origin_date column. Just FYI(gzipped to attach here 2024-02-25-CU-RSV_SVIRS.parquet.gz<https://github.com/HopkinsIDD/rsv-forecast-hub/files/14453454/2024-02-25-CU-RSV_SVIRS.parquet.gz>). By using it, only one remaining issue is:
✖ 2024-02-25-CU-RSV_SVIRS.parquet: `tbl` contains invalid values/value combinations. Column `output_type_id` contains
invalid values "0.15000000000000002", "0.35000000000000003", "0.49999999999999994", "0.5499999999999999",
"0.5999999999999999", "0.6499999999999999", "0.7999999999999999", and "0.8999999999999999".
Please take a look at the contents and see if there is a possibility of correction
—
Reply to this email directly, view it on GitHub<#7 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABSAKVPNZDDLNVUSOT4QIH3YV6KYPAVCNFSM6AAAAABD27SLCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRHE2DONZRGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @tkcy |
Thanks, that looks good. |
okay, I will proceed with it |
modified its name in token_test.yaml
No description provided.